Include local_part as appservice transaction destination #110
Labels
No labels
Android
CS::needs customer feedback
CS::needs follow up
CS::needs on prem installation
CS::waiting
Chrome
Design:: Ready
Design:: in progress
Design::UX
E2EE
Edge
Firefox
GDPR
Iteration 13 IM
Linux
MacOS
Need::Discussion
Need::Steps to reproduce
Need::Upstream fix
Needs:: Planning
Needs::Dev-Team
Needs::More information
Needs::Priority
Needs::Product
Needs::Refinement
Needs::Severity
Priority::1-Critical
Priority::2-Max
Priority::3-Impending
Priority::4-High
Priority::5-Medium
Priority::6-Low
Priority::7-None
Progress::Backlog
Progress::Review
Progress::Started
Progress::Testing
Progress::Triage
Progress::Waiting
Reporter::Sentry
Safari
Target::Community
Target::Customer
Target::Internal
Target::PoC
Target::Security
Team:Customer-Success
Team:Design
Team:Infrastructure
Team:Instant-Messaging
Team:Product
Team:Workflows
Type::Bug
Type::Design
Type::Documentation
Type::Feature
Type::Improvement
Type::Support
Type::Tests
Windows
blocked
blocked-by-spec
cla-signed
conduit
contribution::advanced
contribution::easy
contribution::help needed
from::review
iOS
p::ti-tenant
performance
product::triage
proposal
refactor
release-blocker
s: dart_openapi_codegen
s::Famedly-Patient
s::Org-Directory
s::Passport-Generator
s::Requeuest
s:CRM
s:Famedly-App
s:Famedly-Web
s:Fhiroxide
s:Fhiroxide-cli
s:Fhiroxide-client
s:Fhirs
s:Hedwig
s:LISA
s:Matrix-Dart-SDK
s:Role-Manager
s:Synapse
s:User-Directory
s:WFS-Matrix
s:Workflow Engine
s:dtls
s:famedly-error
s:fcm-shared-isolate
s:matrix-api-lite
s:multiple-tab-detector
s:native-imaging
severity::1
severity::2
severity::3
severity::4
technical-debt
voip
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Matthias/conduit#110
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Headline
Conduit does not send transactions for the appservice itself if local_part of the registration file does not match it.
Description
To be inline with Synapse and Dendrite Conduit should send transactions for appservices for their own local_part, at least when the local user is registered by the appservice.
Most if not all appservices expect this behavior and don't default to having a regex for the local_part when creating a registration file.
Also see https://github.com/hifi/heisenbridge/issues/134
Hmm I thought this was the case already
https://gitlab.com/famedly/conduit/-/blob/master/src/database/rooms.rs#L1511
This code should send all events to the appservice if the bridge user is joined. Perhaps someone can insert a few dbg!s to see what is happening
changed the description
I tested this myself now and I can confirm with latest GitLab docker registry image that I can't talk with Heisenbridge unless I add it to users namespace explicitly.
Can someone test this again with conduit 0.2?
I had to add
- regex: '@heisenbridge'
to the registration file I sent to conduit for heisenbridge to receive invitation events, so I think this is still an issue.Ah I found the problem. we check if the bridge user is in the room, not if it is invited. We should compare the state_key of the new pdu with the user of the localpart
mentioned in merge request !331
mentioned in commit
272e27ae01
mentioned in commit
9046223e7f