Missing state_keys in initial state events aren't replaced by empty strings #116

Closed
opened 2021-07-21 07:32:40 +00:00 by phesch · 3 comments
phesch commented 2021-07-21 07:32:40 +00:00 (Migrated from gitlab.com)

Description

When creating a new room, initial state events are not required to have state_keys according to the Matrix specification.
However, ruma expects all state events to have at least an empty state_key - otherwise, there will be a panic in event_auth.

This problem was first discussed in ruma issue #665,
where it was decided that this is actually a conduit bug.

System Configuration

This affects the current master branch on any OS.

Conduit Version: master (7d14a46607)
Database backend (default is sqlite): any

I would like to fix this issue and submit a merge request later today.

<!-- If you're requesting a new feature, that isn't part of this project yet, then please consider filling out a "Feature Request" instead! If you need a hand setting up your conduit server, feel free to ask for help in the Conduit Matrix Chat: https://matrix.to/#/#conduit:fachschaften.org. --> ### Description <!-- What did you do and what happened? Why is that bad? --> When creating a new room, initial state events are not required to have `state_key`s according to the Matrix specification. However, ruma expects all state events to have at least an empty `state_key` - otherwise, there will be a panic in `event_auth`. This problem was first discussed in [ruma issue #665](https://github.com/ruma/ruma/issues/665), where it was decided that this is actually a conduit bug. ### System Configuration <!-- Other data that might help us debug this issue, like os, conduit version, database backend --> This affects the current master branch on any OS. Conduit Version: master (7d14a4660748e39abffcd4b9c43fb6164aac7d21) Database backend (default is sqlite): any I would like to fix this issue and submit a merge request later today.
phesch commented 2021-07-21 07:32:40 +00:00 (Migrated from gitlab.com)

assigned to @phesch

assigned to @phesch
phesch commented 2021-07-21 09:08:58 +00:00 (Migrated from gitlab.com)

mentioned in merge request !136

mentioned in merge request !136
timokoesters commented 2021-07-21 10:03:09 +00:00 (Migrated from gitlab.com)

mentioned in commit cae2b200cc

mentioned in commit cae2b200cc09f6c301f02a87b337522e6e79d03d
Sign in to join this conversation.
No labels
Android
CS::needs customer feedback
CS::needs follow up
CS::needs on prem installation
CS::waiting
Chrome
Design:: Ready
Design:: in progress
Design::UX
E2EE
Edge
Firefox
GDPR
Iteration 13 IM
Linux
MacOS
Need::Discussion
Need::Steps to reproduce
Need::Upstream fix
Needs:: Planning
Needs::Dev-Team
Needs::More information
Needs::Priority
Needs::Product
Needs::Refinement
Needs::Severity
Priority::1-Critical
Priority::2-Max
Priority::3-Impending
Priority::4-High
Priority::5-Medium
Priority::6-Low
Priority::7-None
Progress::Backlog
Progress::Review
Progress::Started
Progress::Testing
Progress::Triage
Progress::Waiting
Reporter::Sentry
Safari
Target::Community
Target::Customer
Target::Internal
Target::PoC
Target::Security
Team:Customer-Success
Team:Design
Team:Infrastructure
Team:Instant-Messaging
Team:Product
Team:Workflows
Type::Bug
Type::Design
Type::Documentation
Type::Feature
Type::Improvement
Type::Support
Type::Tests
Windows
blocked
blocked-by-spec
cla-signed
conduit
contribution::advanced
contribution::easy
contribution::help needed
from::review
iOS
p::ti-tenant
performance
product::triage
proposal
refactor
release-blocker
s: dart_openapi_codegen
s::Famedly-Patient
s::Org-Directory
s::Passport-Generator
s::Requeuest
s:CRM
s:Famedly-App
s:Famedly-Web
s:Fhiroxide
s:Fhiroxide-cli
s:Fhiroxide-client
s:Fhirs
s:Hedwig
s:LISA
s:Matrix-Dart-SDK
s:Role-Manager
s:Synapse
s:User-Directory
s:WFS-Matrix
s:Workflow Engine
s:dtls
s:famedly-error
s:fcm-shared-isolate
s:matrix-api-lite
s:multiple-tab-detector
s:native-imaging
severity::1
severity::2
severity::3
severity::4
technical-debt
voip
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Matthias/conduit#116
No description provided.