Add support for room versions 7, 8, and 9 #161

Closed
opened 2021-09-15 02:30:36 +00:00 by unbeatable-101 · 17 comments
unbeatable-101 commented 2021-09-15 02:30:36 +00:00 (Migrated from gitlab.com)

#lounge:privacytools.io is going to update its room version soon, and I would like to be able to join the room.

Describe the solution you'd like

Support for the newer rooms to be added.

<!-- If you want to report a bug or an error, then please consider filling out a "Bug Report" instead! --> ### Is your feature request related to a problem? Please describe. <!-- Eg. I'm always frustrated when [...] --> #lounge:privacytools.io is going to update its room version soon, and I would like to be able to join the room. ### Describe the solution you'd like Support for the newer rooms to be added.
jplatte commented 2021-09-15 08:29:30 +00:00 (Migrated from gitlab.com)

These need to first be added to ruma-identifiers and ruma-state-res should be updated to support them (which might be a trivial addition in some match if no state-res related changes were done in these versions).

Also, where is the MSC for v9? I see only v7 and v8 have made it into the unstable spec.

These need to first be added to ruma-identifiers and ruma-state-res should be updated to support them (which might be a trivial addition in some match if no state-res related changes were done in these versions). Also, where is the MSC for v9? I see only v7 and v8 have made it into the unstable spec.
unbeatable-101 commented 2021-09-15 11:00:06 +00:00 (Migrated from gitlab.com)

I could only find the MSC on GitHub for v9, but it had been merged. It was just one change to fix a bug in v8

I could only find the MSC on GitHub for v9, but it had been merged. It was just one change to fix a bug in v8
jplatte commented 2021-09-15 11:02:52 +00:00 (Migrated from gitlab.com)

Yes, that's what I'm interested in. Could you link to it please?

Yes, that's what I'm interested in. Could you link to it please?
unbeatable-101 commented 2021-09-15 11:12:13 +00:00 (Migrated from gitlab.com)
https://github.com/matrix-org/matrix-doc/pull/3375
jplatte commented 2021-09-15 18:34:47 +00:00 (Migrated from gitlab.com)

Corresponding Ruma issue: https://github.com/ruma/ruma/issues/718

Corresponding Ruma issue: https://github.com/ruma/ruma/issues/718
marek-lach commented 2021-09-22 08:24:37 +00:00 (Migrated from gitlab.com)

Related to:

Restricting room membership based on membership in other rooms, which should also be implemented by Conduit at some point

and also see for it's implementation via:

verify if joins are from an authorized server.

Related to: [Restricting room membership based on membership in other rooms](https://github.com/matrix-org/matrix-doc/pull/3083), which should also be implemented by Conduit at some point and also see for it's implementation via: [verify if joins are from an authorized server](https://github.com/matrix-org/synapse/pull/10254).
Mikaela commented 2021-10-03 11:05:52 +00:00 (Migrated from gitlab.com)

This is an important reason why I would like to upgrade several rooms to v9 as managing their invites separately feels like a nightmare while space restricted rooms would be so much more practical. My current blocker is that the rooms have multiple important Conduit users that we don't want to lock out.

This is an important reason why I would like to upgrade several rooms to v9 as managing their invites separately feels like a nightmare while space restricted rooms would be so much more practical. My current blocker is that the rooms have multiple important Conduit users that we don't want to lock out.
unbeatable-101 commented 2021-12-17 20:11:32 +00:00 (Migrated from gitlab.com)

The ruma issue was closed with https://github.com/ruma/ruma/pull/771

The ruma issue was closed with https://github.com/ruma/ruma/pull/771
shsorbom commented 2021-12-17 21:23:55 +00:00 (Migrated from gitlab.com)

So are we just waiting on a ruma upgrade now?

So are we just waiting on a ruma upgrade now?
amorgan commented 2022-01-26 17:51:37 +00:00 (Migrated from gitlab.com)

Hello there. Matrix 1.2, due to be released ~February 2nd, may recommend room v9 as the default homeserver implementation: https://github.com/matrix-org/matrix-doc/pull/3589#discussion_r792891764. This would have the consequence of introducing a lot more v9 rooms into the network.

It's a known point that conduit does not yet support this room version. Are the blockers known for why this issue has stalled, and if so, are they feasible to unblock in a short time-frame?

Hello there. Matrix 1.2, due to be released ~February 2nd, may **recommend** room v9 as the default homeserver implementation: https://github.com/matrix-org/matrix-doc/pull/3589#discussion_r792891764. This would have the consequence of introducing a lot more v9 rooms into the network. It's a known point that conduit does not yet support this room version. Are the blockers known for why this issue has stalled, and if so, are they feasible to unblock in a short time-frame?
timokoesters commented 2022-01-26 18:02:44 +00:00 (Migrated from gitlab.com)

There's an MR for more room versions here: !257
It currently has some bugs in the auth rules which have to be fixed in ruma.

There's an MR for more room versions here: !257 It currently has some bugs in the auth rules which have to be fixed in ruma.
amorgan commented 2022-01-26 18:10:40 +00:00 (Migrated from gitlab.com)

Aha, thank you @timokoesters. I'm glad to see that this issue hasn't simply stalled.

As contributors here are much closer to conduit than I am myself, I am curious for their thoughts on https://github.com/matrix-org/matrix-doc/pull/3589#discussion_r792891764.

Aha, thank you @timokoesters. I'm glad to see that this issue hasn't simply stalled. As contributors here are much closer to conduit than I am myself, I am curious for their thoughts on https://github.com/matrix-org/matrix-doc/pull/3589#discussion_r792891764.
jfowl commented 2022-02-20 09:30:49 +00:00 (Migrated from gitlab.com)

mentioned in merge request !257

mentioned in merge request !257
ptman commented 2022-03-02 15:50:07 +00:00 (Migrated from gitlab.com)

room version 9 will soon be default in synapse

room version 9 will soon be default in synapse
timokoesters commented 2022-04-07 15:28:00 +00:00 (Migrated from gitlab.com)

mentioned in commit 6e106b5732

mentioned in commit 6e106b573232effc8e245321af5c5353c5550729
poVoq commented 2022-04-14 15:45:38 +00:00 (Migrated from gitlab.com)

How do I upgrade existing v6 rooms to v9?

How do I upgrade existing v6 rooms to v9?
cel commented 2022-04-14 17:04:02 +00:00 (Migrated from gitlab.com)

Hi @poVoq,
In Element it's /upgraderoom, and also in various prompts. Quaternion has a GUI command for it too.
Upgrade creates a new room, optionally inviting the previous members, and redirects/tombstones the existing room to the new one.

Hi @poVoq, In Element it's `/upgraderoom`, and also in various prompts. Quaternion has a GUI command for it too. Upgrade creates a new room, optionally inviting the previous members, and redirects/tombstones the existing room to the new one.
Sign in to join this conversation.
No labels
Android
CS::needs customer feedback
CS::needs follow up
CS::needs on prem installation
CS::waiting
Chrome
Design:: Ready
Design:: in progress
Design::UX
E2EE
Edge
Firefox
GDPR
Iteration 13 IM
Linux
MacOS
Need::Discussion
Need::Steps to reproduce
Need::Upstream fix
Needs:: Planning
Needs::Dev-Team
Needs::More information
Needs::Priority
Needs::Product
Needs::Refinement
Needs::Severity
Priority::1-Critical
Priority::2-Max
Priority::3-Impending
Priority::4-High
Priority::5-Medium
Priority::6-Low
Priority::7-None
Progress::Backlog
Progress::Review
Progress::Started
Progress::Testing
Progress::Triage
Progress::Waiting
Reporter::Sentry
Safari
Target::Community
Target::Customer
Target::Internal
Target::PoC
Target::Security
Team:Customer-Success
Team:Design
Team:Infrastructure
Team:Instant-Messaging
Team:Product
Team:Workflows
Type::Bug
Type::Design
Type::Documentation
Type::Feature
Type::Improvement
Type::Support
Type::Tests
Windows
blocked
blocked-by-spec
cla-signed
conduit
contribution::advanced
contribution::easy
contribution::help needed
from::review
iOS
p::ti-tenant
performance
product::triage
proposal
refactor
release-blocker
s: dart_openapi_codegen
s::Famedly-Patient
s::Org-Directory
s::Passport-Generator
s::Requeuest
s:CRM
s:Famedly-App
s:Famedly-Web
s:Fhiroxide
s:Fhiroxide-cli
s:Fhiroxide-client
s:Fhirs
s:Hedwig
s:LISA
s:Matrix-Dart-SDK
s:Role-Manager
s:Synapse
s:User-Directory
s:WFS-Matrix
s:Workflow Engine
s:dtls
s:famedly-error
s:fcm-shared-isolate
s:matrix-api-lite
s:multiple-tab-detector
s:native-imaging
severity::1
severity::2
severity::3
severity::4
technical-debt
voip
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Matthias/conduit#161
No description provided.