Matthias/conduit

Fork 0

Missing global notification options. #264

New issue

Open

opened 2022-04-17 19:02:20 +00:00 by MyBeansAreBaked · 11 comments

MyBeansAreBaked commented

2022-04-17 19:02:20 +00:00

(Migrated from gitlab.com)

Description

Global notification options aren't avaliable.

For comparison, on (my same server) running synapse:

This behaviour is the same on element android, too.

Also, I don't know if it is related, but changing room specific notification settings doesn't seem to work every time.

This issue https://gitlab.com/famedly/conduit/-/issues/2 seems related, but dead.

System Configuration

Running the matrixconduit/matrix-conduit:latest docker image using podman (on alpine linux host), behind an nginx reverse proxy.

Database backend: sqlite

### Description  Global notification options aren't avaliable. ![image](/uploads/02034f0da9f7d6c8d7d63eb3d8ad244f/image.png) For comparison, on (my same server) running synapse: ![image](/uploads/104f6eae30327b83a425d331557f5a09/image.png) This behaviour is the same on element android, too. Also, I don't know if it is related, but changing room specific notification settings doesn't seem to work every time. This issue https://gitlab.com/famedly/conduit/-/issues/2 seems related, but dead. ### System Configuration  Running the `matrixconduit/matrix-conduit:latest` docker image using podman (on alpine linux host), behind an nginx reverse proxy. Database backend: sqlite

M0dEx commented

2022-04-17 19:06:44 +00:00

(Migrated from gitlab.com)

marked this issue as related to #265

M0dEx commented

2022-04-17 19:07:14 +00:00

(Migrated from gitlab.com)

assigned to @M0dEx

M0dEx commented

2022-04-17 19:09:48 +00:00

(Migrated from gitlab.com)

As far as I can tell, all endpoints are implemented, there are no 404 responses.

I will take a look into how Element and Conduit initialize global notification rules.

As far as I can tell, all endpoints are implemented, there are no 404 responses. I will take a look into how Element and Conduit initialize global notification rules.

M0dEx commented

2022-04-17 20:07:39 +00:00

(Migrated from gitlab.com)

I think I have found the culprit!

Underride (global) rule IDs when using Synapse:

.m.rule.call
.m.rule.room_one_to_one
.m.rule.encrypted_room_one_to_one
.m.rule.message
.m.rule.encrypt

Underride (global) rule IDs when using Conduit:

.m.rules.call
.m.rules.room_one_to_one
.m.rules.encrypted_room_one_to_one
.m.rules.message
.m.rules.encrypt

Notice the .m.rule vs .m.rules.
This does not happen for rule IDs in the Override section.

As far as I can tell, these IDs are generated by ruma. I will open an issue on the ruma GitHub repository.

I think I have found the culprit! `Underride` (global) rule IDs when using Synapse: ``` .m.rule.call .m.rule.room_one_to_one .m.rule.encrypted_room_one_to_one .m.rule.message .m.rule.encrypt ``` `Underride` (global) rule IDs when using Conduit: ``` .m.rules.call .m.rules.room_one_to_one .m.rules.encrypted_room_one_to_one .m.rules.message .m.rules.encrypt ``` Notice the `.m.rule` vs `.m.rules`. This does not happen for rule IDs in the `Override` section. As far as I can tell, [these IDs are generated by ruma](https://github.com/ruma/ruma/blob/3ec82181581b6411d2fa96c196bc96052236d3a5/crates/ruma-common/src/push/predefined.rs#L196). I will open an issue on the ruma GitHub repository.

M0dEx commented

2022-04-17 20:14:48 +00:00

(Migrated from gitlab.com)

Ruma issue: ~~https://github.com/ruma/ruma/issues/1075~~ Closed

Ruma issue: ~~https://github.com/ruma/ruma/issues/1075~~ **Closed**

M0dEx commented

2022-04-17 20:25:39 +00:00

(Migrated from gitlab.com)

Ruma PR with fix: ~~https://github.com/ruma/ruma/pull/1076~~ Merged

Ruma PR with fix: ~~https://github.com/ruma/ruma/pull/1076~~ **Merged**

M0dEx commented

2022-04-17 21:26:44 +00:00

(Migrated from gitlab.com)

Now we just need to:

update ruma to (at least) commit 09ac0aa3ac30beff5a435cbcfbda5fde3b5c1d0e
write a DB migration

Now we just need to: - [ ] update ruma to (at least) commit `09ac0aa3ac30beff5a435cbcfbda5fde3b5c1d0e` - [ ] write a DB migration

beziarum commented

2022-10-13 15:56:30 +00:00

(Migrated from gitlab.com)

I will try to fix this issue.
On this, I have one question : do you think it is best to update ruma to commit 09ac0a or to the latest release (version 0.7.4 on commit cee3d2f) ?

I will try to fix this issue. On this, I have one question : do you think it is best to update ruma to commit 09ac0a or to the latest release (version 0.7.4 on commit cee3d2f) ?

timokoesters commented

2022-10-13 15:57:28 +00:00

(Migrated from gitlab.com)

I updated ruma to the most recent commit yesterday, you should be fine :)

beziarum commented

2022-10-18 09:26:55 +00:00

(Migrated from gitlab.com)

mentioned in merge request !405