Element requires result count when searching #27

Closed
opened 2020-11-24 17:42:54 +00:00 by gbsf · 6 comments
gbsf commented 2020-11-24 17:42:54 +00:00 (Migrated from gitlab.com)

If it's not present, Element won't show the results, even though they were returned correctly.

If it's not present, Element won't show the results, even though they were returned correctly.
timokoesters commented 2020-12-05 22:41:46 +00:00 (Migrated from gitlab.com)

Is this a bug in element? The spec says this is optional. Conduit doesn't do this to be more efficient

Is this a bug in element? The spec says this is optional. Conduit doesn't do this to be more efficient
gbsf commented 2020-12-05 22:52:07 +00:00 (Migrated from gitlab.com)

Probably, I'd have to look at their code.
I opened this more for documentation.

Anyway, supporting this is a nice-to-have.

Probably, I'd have to look at their code. I opened this more for documentation. Anyway, supporting this is a nice-to-have.
timokoesters commented 2020-12-05 22:55:32 +00:00 (Migrated from gitlab.com)

We could do something like searching through the database to count, but only up to some limit, like 100. But we don't want someone to search for "a" and cause conduit to go through almost every message

We could do something like searching through the database to count, but only up to some limit, like 100. But we don't want someone to search for "a" and cause conduit to go through almost every message
timokoesters commented 2020-12-05 22:59:10 +00:00 (Migrated from gitlab.com)

Also this seems like a recent addition. Not long ago search (with at least one result) worked perfectly

Also this seems like a recent addition. Not long ago search (with at least one result) worked perfectly
tomkwok commented 2020-12-06 09:47:46 +00:00 (Migrated from gitlab.com)

I found that the last version with a working search is Element 1.7.9.

I found that the last version with a working search is Element 1.7.9.
timokoesters commented 2021-01-10 15:30:19 +00:00 (Migrated from gitlab.com)

I wrote a commit so Conduit returns a result count between 0 and limit where limit is what the client requested or the default=10. We return the limit even if there are more results

I wrote a commit so Conduit returns a result count between 0 and `limit` where limit is what the client requested or the default=10. We return the limit even if there are more results
Sign in to join this conversation.
No labels
Android
CS::needs customer feedback
CS::needs follow up
CS::needs on prem installation
CS::waiting
Chrome
Design:: Ready
Design:: in progress
Design::UX
E2EE
Edge
Firefox
GDPR
Iteration 13 IM
Linux
MacOS
Need::Discussion
Need::Steps to reproduce
Need::Upstream fix
Needs:: Planning
Needs::Dev-Team
Needs::More information
Needs::Priority
Needs::Product
Needs::Refinement
Needs::Severity
Priority::1-Critical
Priority::2-Max
Priority::3-Impending
Priority::4-High
Priority::5-Medium
Priority::6-Low
Priority::7-None
Progress::Backlog
Progress::Review
Progress::Started
Progress::Testing
Progress::Triage
Progress::Waiting
Reporter::Sentry
Safari
Target::Community
Target::Customer
Target::Internal
Target::PoC
Target::Security
Team:Customer-Success
Team:Design
Team:Infrastructure
Team:Instant-Messaging
Team:Product
Team:Workflows
Type::Bug
Type::Design
Type::Documentation
Type::Feature
Type::Improvement
Type::Support
Type::Tests
Windows
blocked
blocked-by-spec
cla-signed
conduit
contribution::advanced
contribution::easy
contribution::help needed
from::review
iOS
p::ti-tenant
performance
product::triage
proposal
refactor
release-blocker
s: dart_openapi_codegen
s::Famedly-Patient
s::Org-Directory
s::Passport-Generator
s::Requeuest
s:CRM
s:Famedly-App
s:Famedly-Web
s:Fhiroxide
s:Fhiroxide-cli
s:Fhiroxide-client
s:Fhirs
s:Hedwig
s:LISA
s:Matrix-Dart-SDK
s:Role-Manager
s:Synapse
s:User-Directory
s:WFS-Matrix
s:Workflow Engine
s:dtls
s:famedly-error
s:fcm-shared-isolate
s:matrix-api-lite
s:multiple-tab-detector
s:native-imaging
severity::1
severity::2
severity::3
severity::4
technical-debt
voip
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Matthias/conduit#27
No description provided.