Conduit improperly returns 200 when querying unknown room ID's #290

Open
opened 2022-07-16 20:54:44 +00:00 by shsorbom · 3 comments
shsorbom commented 2022-07-16 20:54:44 +00:00 (Migrated from gitlab.com)

Description

When using put /_matrix/client/v3/directory/list/room/{roomId} on an unknown room, conduit returns 200 status and empty json. Tested via the matrix api website. It looks like it should return 404 with this status:

{
  "errcode": "M_NOT_FOUND",
  "error": "Room not found"
}

System Configuration

Conduit Version: 0.40
Database backend (default is sqlite): rocksdb

<!-- If you're requesting a new feature, that isn't part of this project yet, then please consider filling out a "Feature Request" instead! If you need a hand setting up your conduit server, feel free to ask for help in the Conduit Matrix Chat: https://matrix.to/#/#conduit:fachschaften.org. --> ### Description When using `put /_matrix/client/v3/directory/list/room/{roomId}` on an unknown room, conduit returns `200` status and empty json. Tested via the matrix api website. It looks like it should return `404` with this status: ``` { "errcode": "M_NOT_FOUND", "error": "Room not found" } ``` ### System Configuration <!-- Other data that might help us debug this issue, like os, conduit version, database backend --> Conduit Version: 0.40 Database backend (default is sqlite): rocksdb
maxjcohen commented 2022-09-10 16:11:35 +00:00 (Migrated from gitlab.com)

Same goes for the GET /_matrix/client/v3/directory/list/room/{roomId} route (https://www.matrix.org/docs/api/#get-/_matrix/client/v3/directory/list/room/-roomId-).

Same goes for the `GET /_matrix/client/v3/directory/list/room/{roomId}` route (https://www.matrix.org/docs/api/#get-/_matrix/client/v3/directory/list/room/-roomId-).
maxjcohen commented 2022-09-10 16:22:56 +00:00 (Migrated from gitlab.com)

mentioned in merge request !383

mentioned in merge request !383
maxjcohen commented 2022-10-15 11:55:56 +00:00 (Migrated from gitlab.com)

mentioned in commit 6fd39ae174

mentioned in commit 6fd39ae174de283a270bbb1fa5516d4f1f4c2897
Sign in to join this conversation.
No labels
Android
CS::needs customer feedback
CS::needs follow up
CS::needs on prem installation
CS::waiting
Chrome
Design:: Ready
Design:: in progress
Design::UX
E2EE
Edge
Firefox
GDPR
Iteration 13 IM
Linux
MacOS
Need::Discussion
Need::Steps to reproduce
Need::Upstream fix
Needs:: Planning
Needs::Dev-Team
Needs::More information
Needs::Priority
Needs::Product
Needs::Refinement
Needs::Severity
Priority::1-Critical
Priority::2-Max
Priority::3-Impending
Priority::4-High
Priority::5-Medium
Priority::6-Low
Priority::7-None
Progress::Backlog
Progress::Review
Progress::Started
Progress::Testing
Progress::Triage
Progress::Waiting
Reporter::Sentry
Safari
Target::Community
Target::Customer
Target::Internal
Target::PoC
Target::Security
Team:Customer-Success
Team:Design
Team:Infrastructure
Team:Instant-Messaging
Team:Product
Team:Workflows
Type::Bug
Type::Design
Type::Documentation
Type::Feature
Type::Improvement
Type::Support
Type::Tests
Windows
blocked
blocked-by-spec
cla-signed
conduit
contribution::advanced
contribution::easy
contribution::help needed
from::review
iOS
p::ti-tenant
performance
product::triage
proposal
refactor
release-blocker
s: dart_openapi_codegen
s::Famedly-Patient
s::Org-Directory
s::Passport-Generator
s::Requeuest
s:CRM
s:Famedly-App
s:Famedly-Web
s:Fhiroxide
s:Fhiroxide-cli
s:Fhiroxide-client
s:Fhirs
s:Hedwig
s:LISA
s:Matrix-Dart-SDK
s:Role-Manager
s:Synapse
s:User-Directory
s:WFS-Matrix
s:Workflow Engine
s:dtls
s:famedly-error
s:fcm-shared-isolate
s:matrix-api-lite
s:multiple-tab-detector
s:native-imaging
severity::1
severity::2
severity::3
severity::4
technical-debt
voip
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Matthias/conduit#290
No description provided.