"sent invalid signature in sendjoin signatures for event" #411
Labels
No labels
Android
CS::needs customer feedback
CS::needs follow up
CS::needs on prem installation
CS::waiting
Chrome
Design:: Ready
Design:: in progress
Design::UX
E2EE
Edge
Firefox
GDPR
Iteration 13 IM
Linux
MacOS
Need::Discussion
Need::Steps to reproduce
Need::Upstream fix
Needs:: Planning
Needs::Dev-Team
Needs::More information
Needs::Priority
Needs::Product
Needs::Refinement
Needs::Severity
Priority::1-Critical
Priority::2-Max
Priority::3-Impending
Priority::4-High
Priority::5-Medium
Priority::6-Low
Priority::7-None
Progress::Backlog
Progress::Review
Progress::Started
Progress::Testing
Progress::Triage
Progress::Waiting
Reporter::Sentry
Safari
Target::Community
Target::Customer
Target::Internal
Target::PoC
Target::Security
Team:Customer-Success
Team:Design
Team:Infrastructure
Team:Instant-Messaging
Team:Product
Team:Workflows
Type::Bug
Type::Design
Type::Documentation
Type::Feature
Type::Improvement
Type::Support
Type::Tests
Windows
blocked
blocked-by-spec
cla-signed
conduit
contribution::advanced
contribution::easy
contribution::help needed
from::review
iOS
p::ti-tenant
performance
product::triage
proposal
refactor
release-blocker
s: dart_openapi_codegen
s::Famedly-Patient
s::Org-Directory
s::Passport-Generator
s::Requeuest
s:CRM
s:Famedly-App
s:Famedly-Web
s:Fhiroxide
s:Fhiroxide-cli
s:Fhiroxide-client
s:Fhirs
s:Hedwig
s:LISA
s:Matrix-Dart-SDK
s:Role-Manager
s:Synapse
s:User-Directory
s:WFS-Matrix
s:Workflow Engine
s:dtls
s:famedly-error
s:fcm-shared-isolate
s:matrix-api-lite
s:multiple-tab-detector
s:native-imaging
severity::1
severity::2
severity::3
severity::4
technical-debt
voip
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Matthias/conduit#411
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
After a report in #conduit:fachschaften.org, I tried to join
#hm:rycee.net
, and I am getting this error in my logs:which does seem valid when I am manually checking it with a custom Python script:
(
k.verify
not raising an exception means the signature is valid)Additionally, Conduit's log looks exactly like the JSON that matrix.org serves when requesting this event:
changed the description
mentioned in merge request !563
Using https://gitlab.com/famedly/conduit/-/merge_requests/563, I see that the underlying error seems to be a missing signature:
BadRequest(InvalidParam, "Server did not send its signature")
More logs, btw:
In https://spec.matrix.org/v1.9/server-server-api/#put_matrixfederationv2send_joinroomideventid the spec says: "The signed copy of the membership event sent to other servers by the resident server, including the resident server’s signature."
So it seems the Synapse at
rycee.net
is to blame hereReproduced with matrix.org and reported to Synapse: https://github.com/matrix-org/synapse/issues/16717
WONTFIX from Synapse: https://github.com/element-hq/synapse/issues/16717#issuecomment-1887343791
Expanding on that: the spec at the time Conduit implemented it was misleading and will be clarified in the future. This means that Conduit will need to change its behavior here. See also https://github.com/matrix-org/matrix-spec/issues/1708
Here's another report of this issue: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$WgBaN0Bdbrwbvlm-OhSmjmh7HgqgjCWHZpdZ4IqpUiw?via=flipdot.org&via=matrix.org&via=conduit.rs