Conduit panicking on failed attempt to get presence info #414
Labels
No labels
Android
CS::needs customer feedback
CS::needs follow up
CS::needs on prem installation
CS::waiting
Chrome
Design:: Ready
Design:: in progress
Design::UX
E2EE
Edge
Firefox
GDPR
Iteration 13 IM
Linux
MacOS
Need::Discussion
Need::Steps to reproduce
Need::Upstream fix
Needs:: Planning
Needs::Dev-Team
Needs::More information
Needs::Priority
Needs::Product
Needs::Refinement
Needs::Severity
Priority::1-Critical
Priority::2-Max
Priority::3-Impending
Priority::4-High
Priority::5-Medium
Priority::6-Low
Priority::7-None
Progress::Backlog
Progress::Review
Progress::Started
Progress::Testing
Progress::Triage
Progress::Waiting
Reporter::Sentry
Safari
Target::Community
Target::Customer
Target::Internal
Target::PoC
Target::Security
Team:Customer-Success
Team:Design
Team:Infrastructure
Team:Instant-Messaging
Team:Product
Team:Workflows
Type::Bug
Type::Design
Type::Documentation
Type::Feature
Type::Improvement
Type::Support
Type::Tests
Windows
blocked
blocked-by-spec
cla-signed
conduit
contribution::advanced
contribution::easy
contribution::help needed
from::review
iOS
p::ti-tenant
performance
product::triage
proposal
refactor
release-blocker
s: dart_openapi_codegen
s::Famedly-Patient
s::Org-Directory
s::Passport-Generator
s::Requeuest
s:CRM
s:Famedly-App
s:Famedly-Web
s:Fhiroxide
s:Fhiroxide-cli
s:Fhiroxide-client
s:Fhirs
s:Hedwig
s:LISA
s:Matrix-Dart-SDK
s:Role-Manager
s:Synapse
s:User-Directory
s:WFS-Matrix
s:Workflow Engine
s:dtls
s:famedly-error
s:fcm-shared-isolate
s:matrix-api-lite
s:multiple-tab-detector
s:native-imaging
severity::1
severity::2
severity::3
severity::4
technical-debt
voip
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Matthias/conduit#414
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
looking at the code, it looks like it could just return
Err()
instead of panicking and crashing the whole server..How do you reproduce this? The existing presence implementation is purely local. First time I'm ever seeing a situation where it failed to get local presence.
Can you reproduce it with
RUST_BACKTRACE=1
?sure, i'll restart Conduit with
RUST_BACKTRACE=1
and wait for the next crash - it happened twice yesterday, so hopefully i'll see some today as wellWhat clients are your users using? I feel like this is just a broken/bad client and Conduit leaving in broken code that makes the client issue obvious.
(fwiw https://gitlab.com/famedly/conduit/-/merge_requests/476/diffs#e72f4e14774e775d11cee027e54c1596abd9620a_82_87 fixes this)
i just reproduced the crash, it would be FluffyChat 1.16.0 from F-Droid; i tried to get the backtrace, but apparently it's built with panic=abort, so... uhm
Try
RUST_BACKTRACE=full
. I think that's how I got at least some details.Does FluffyChat have some sort of custom status feature or something? Or is it actually just opening up the app and it crashes?
the stacktrace unfortunately seems quite useless 😕:
full stack backtrace
i'm just opening one of the rooms i'm in and it crashes; when i do the same on Element, it shows another local user as online, but myself as offline..
Damn, oh well :<
The fix is reviewing and merging that MR I linked hopefully in the next few years.
Having the same problem! Been seeing this for a couple of days now in my log.
Using FluffyChat iOS version 1.16.0 as client.
Any idea how to fix this issue?
@BobWs if you can build from source, you need the one-line change from https://gitlab.com/famedly/conduit/-/merge_requests/476/diffs#e72f4e14774e775d11cee027e54c1596abd9620a_82_87.
Or you can block those requests (
GET /_matrix/client/r0/presence/{userId}/status
) from a reverse proxy.This was fixed in https://gitlab.com/famedly/conduit/-/merge_requests/565