Unable to reject room invites #418

Open
opened 2024-01-18 23:06:58 +00:00 by schrottkatze · 10 comments
schrottkatze commented 2024-01-18 23:06:58 +00:00 (Migrated from gitlab.com)

Description

I got invited to malicious rooms and I am unable to even reject the invites.

System Configuration

Conduit Version: 0.7.0-alpha
Database backend (default is sqlite): sqlite
OS: NixOS

<!-- If you're requesting a new feature, that isn't part of this project yet, then please consider filling out a "Feature Request" instead! If you need a hand setting up your conduit server, feel free to ask for help in the Conduit Matrix Chat: https://matrix.to/#/#conduit:fachschaften.org. --> ### Description <!-- What did you do and what happened? Why is that bad? --> I got invited to malicious rooms and I am unable to even reject the invites. ### System Configuration <!-- Other data that might help us debug this issue, like os, conduit version, database backend --> Conduit Version: 0.7.0-alpha Database backend (default is sqlite): sqlite OS: NixOS
CobaltCause commented 2024-01-19 22:47:42 +00:00 (Migrated from gitlab.com)

More context: apparently they rejected the invite and then cleared FluffyChat's entire app cache but the invite was still there? Link to their message in Matrix about it.

More context: apparently they rejected the invite and then cleared FluffyChat's entire app cache but the invite was still there? [Link](https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$sXHpF2yRUWyJw5ypUbXcL_lnSBS-jWyj7sYRYg7gcRY?via=flipdot.org&via=matrix.org&via=conduit.rs) to their message in Matrix about it.
CobaltCause commented 2024-01-19 23:16:03 +00:00 (Migrated from gitlab.com)

Other times this kind of issue has been reported (I just searched for "reject" in Conduit's Matrix room so I probably missed some instances too):

  1. @herkulessi:herkinf.de on 2023-10-08: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$4hl32P2yzDQQC6FX11pFdN5AuOZTqWsIV5U_JaL201o?via=flipdot.org&via=matrix.org&via=conduit.rs
  2. @cubic:cubicfluff.pl on 2023-09-22: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$ydBZcWPEXyvy5QrkaPwLjqXPqvztCXBG14nsbfa_XXU?via=flipdot.org&via=matrix.org&via=conduit.rs
  3. @axerr:axerr.dev on 2023-09-04: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$uxj0ad1uQAJVwFxfvr66KrnWt-knR8fUdgv21tnNzS8?via=flipdot.org&via=matrix.org&via=conduit.rs
  4. @axerr:axerr.dev on 2023-08-15: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$2e3lJlDp5MieCEHHG03XEsYGb9jm-qnkxZ8qsEZrry0?via=flipdot.org&via=matrix.org&via=conduit.rs
  5. @xormetric:tentacle.expert on 2023-07-06: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$OAfnACOJrBdkW7JCzar2EMb49crgvutUKqwaGOG5DzI?via=flipdot.org&via=matrix.org&via=conduit.rs
  6. @notruthsaga:chat.lamer-ethos.site on 2023-06-27: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$-E5mLj1QhtKLaNEpw0FnVJFsVEMpy2YktMYCTBwlJTk?via=flipdot.org&via=matrix.org&via=conduit.rs
  7. @r3g_5z:girlboss.ceo on 2023-03-15: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$iwLWoGOp3RD9UvVpeH6rAZeF-DaCLYHOqEfK9T0IaYc?via=flipdot.org&via=matrix.org&via=conduit.rs
  8. @follpvosten:karp.lol on 2023-03-13: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$g5o8cceOvnGrdvoWJNPXIkWXUhB6pKtKRghmZVlN6kw?via=flipdot.org&via=matrix.org&via=conduit.rs
  9. @r3g_5z:girlboss.ceo on 2023-02-20: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$q81zvTBH3tEUe5cBXBJKg8oJ9io3E5LH5qPAHDzaKWI?via=flipdot.org&via=matrix.org&via=conduit.rs
  10. @j:tjm.sk on 2023-01-09: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$P2p4wAav0WnLvzo28xSeztLEonqwkMYArSUN0yb1AHw?via=flipdot.org&via=matrix.org&via=conduit.rs
  11. @blu3r4d0n:matrix.shutdown.network on 2022-12-12: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$DSiJn4HJa6meDv8vJ6YAv4-yz8k552AYI-lRT3BByaI?via=flipdot.org&via=matrix.org&via=conduit.rs

I'll add that I also personally experience this every time I get invited to a room and try to reject it since I started running Conduit on 2022-01-24 but never reported it myself because I had seen so many other people complain about it and seen the solution (clearing your cache) posted enough that I assumed an issue was already filed and never brought it up myself because I knew the workaround.

What I find interesting about this particular report is that it claims that clearing the cache doesn't work. I didn't comb through all of the other examples that I posted above but it seems like that fixes it for pretty much everyone else, including me.

Other times this kind of issue has been reported (I just searched for "reject" in Conduit's Matrix room so I probably missed some instances too): 1. `@herkulessi:herkinf.de` on 2023-10-08: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$4hl32P2yzDQQC6FX11pFdN5AuOZTqWsIV5U_JaL201o?via=flipdot.org&via=matrix.org&via=conduit.rs 1. `@cubic:cubicfluff.pl` on 2023-09-22: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$ydBZcWPEXyvy5QrkaPwLjqXPqvztCXBG14nsbfa_XXU?via=flipdot.org&via=matrix.org&via=conduit.rs 1. `@axerr:axerr.dev` on 2023-09-04: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$uxj0ad1uQAJVwFxfvr66KrnWt-knR8fUdgv21tnNzS8?via=flipdot.org&via=matrix.org&via=conduit.rs 1. `@axerr:axerr.dev` on 2023-08-15: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$2e3lJlDp5MieCEHHG03XEsYGb9jm-qnkxZ8qsEZrry0?via=flipdot.org&via=matrix.org&via=conduit.rs 1. `@xormetric:tentacle.expert` on 2023-07-06: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$OAfnACOJrBdkW7JCzar2EMb49crgvutUKqwaGOG5DzI?via=flipdot.org&via=matrix.org&via=conduit.rs 1. `@notruthsaga:chat.lamer-ethos.site` on 2023-06-27: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$-E5mLj1QhtKLaNEpw0FnVJFsVEMpy2YktMYCTBwlJTk?via=flipdot.org&via=matrix.org&via=conduit.rs 1. `@r3g_5z:girlboss.ceo` on 2023-03-15: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$iwLWoGOp3RD9UvVpeH6rAZeF-DaCLYHOqEfK9T0IaYc?via=flipdot.org&via=matrix.org&via=conduit.rs 1. `@follpvosten:karp.lol` on 2023-03-13: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$g5o8cceOvnGrdvoWJNPXIkWXUhB6pKtKRghmZVlN6kw?via=flipdot.org&via=matrix.org&via=conduit.rs 1. `@r3g_5z:girlboss.ceo` on 2023-02-20: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$q81zvTBH3tEUe5cBXBJKg8oJ9io3E5LH5qPAHDzaKWI?via=flipdot.org&via=matrix.org&via=conduit.rs 1. `@j:tjm.sk` on 2023-01-09: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$P2p4wAav0WnLvzo28xSeztLEonqwkMYArSUN0yb1AHw?via=flipdot.org&via=matrix.org&via=conduit.rs 1. `@blu3r4d0n:matrix.shutdown.network` on 2022-12-12: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$DSiJn4HJa6meDv8vJ6YAv4-yz8k552AYI-lRT3BByaI?via=flipdot.org&via=matrix.org&via=conduit.rs I'll add that I also personally experience this every time I get invited to a room and try to reject it since I started running Conduit on 2022-01-24 but never reported it myself because I had seen so many other people complain about it and seen the solution (clearing your cache) posted enough that I assumed an issue was already filed and never brought it up myself because I knew the workaround. What I find interesting about this particular report is that it claims that clearing the cache doesn't work. I didn't comb through all of the other examples that I posted above but it seems like that fixes it for pretty much everyone else, including me.
CobaltCause commented 2024-01-19 23:24:00 +00:00 (Migrated from gitlab.com)

Definitely a server issue. The server should be local-rejecting the room invite and removing it from your client via /sync.

@t3chguy on GitHub, 2023-11-07

> Definitely a server issue. The server should be local-rejecting the room invite and removing it from your client via `/sync`. &mdash; [`@t3chguy` on GitHub, 2023-11-07](https://github.com/element-hq/element-web/issues/26514#issuecomment-1798052005)
CobaltCause commented 2024-01-23 15:15:14 +00:00 (Migrated from gitlab.com)
13. `@nki:m.nkagami.me` on 2023-01-23: https://matrix.to/#/!SMloEYlhCiqKwRLAgY:fachschaften.org/$Lpg6YkuzjB2LHrQYoLszabtI-smnO0Lf7TKYYVQ3IHc?via=flipdot.org&via=matrix.org&via=conduit.rs
CobaltCause commented 2024-01-24 23:47:00 +00:00 (Migrated from gitlab.com)
14. https://gitlab.com/famedly/conduit/-/issues/401 15. https://gitlab.com/famedly/conduit/-/issues/401#note_1666735445
schrottkatze commented 2024-01-25 07:19:02 +00:00 (Migrated from gitlab.com)

I had seen so many other people complain about it and seen the solution (clearing your cache) posted enough that I assumed an issue was already filed and never brought it up myself because I knew the workaround.

Tbh, just knowing a workaround and telling other people that is... meh.

Especially if the workaround doesn't work in all cases (I switched to element on my laptop now, but don't intend to do so on my phone and there I still can't reject or clear the cache and can't open the groups without getting triggered).

> I had seen so many other people complain about it and seen the solution (clearing your cache) posted enough that I assumed an issue was already filed and never brought it up myself because I knew the workaround. Tbh, just knowing a workaround and telling other people that is... meh. Especially if the workaround doesn't work in all cases (I switched to element on my laptop now, but don't intend to do so on my phone and there I still can't reject or clear the cache and can't open the groups without getting triggered).
CobaltCause commented 2024-01-25 09:48:20 +00:00 (Migrated from gitlab.com)

The point of the quoted section is to explain why I, personally, never bothered to open an issue for this, that I feel this was a failure on my part, and that I feel bad about it. I am absolutely not trying to justify the status quo here.

I collected all of the above examples of this being reported time and again in the hopes that it will draw some attention (ideally resulting in a solution) to this problem.

The point of the quoted section is to explain why I, personally, never bothered to open an issue for this, that I feel this was a failure on my part, and that I feel bad about it. I am absolutely not trying to justify the status quo here. I collected all of the above examples of this being reported time and again in the hopes that it will draw some attention (ideally resulting in a solution) to this problem.
timokoesters commented 2024-01-28 19:38:15 +00:00 (Migrated from gitlab.com)

mentioned in issue #401

mentioned in issue #401
MultisampledNight commented 2024-02-04 13:43:28 +00:00 (Migrated from gitlab.com)

I'd want to work on this, currently trying to find my way into the codebase.

Can't seem to join the matrix chat at #conduit:fachschaften.org using fluffychat on NixOS with a bare Oops, something went wrong error (all other rooms on fachschaften.org are also displayed, just the conduit one isn't), so I guess I'll just communicate here and keep noise to a minimum.

I'd want to work on this, currently trying to find my way into the codebase. Can't seem to join the matrix chat at #conduit:fachschaften.org using fluffychat on NixOS with a bare `Oops, something went wrong` error (all other rooms on fachschaften.org are also displayed, just the conduit one isn't), so I guess I'll just communicate here and keep noise to a minimum.
MultisampledNight commented 2024-02-04 15:19:06 +00:00 (Migrated from gitlab.com)

Fwiw a repro is at https://github.com/element-hq/element-web/issues/26514, but trying it out with a single non-federated local instance does not result in the errornous behavior and the invite is rejected just fine.

I'll try setting up a second local conduit instance and test with having these two federate. If that doesn't result in anything interesting, I'll try it with Synapse instead, maybe it's a funny interaction.

Fwiw a repro is at https://github.com/element-hq/element-web/issues/26514, but trying it out with a single non-federated local instance does not result in the errornous behavior and the invite is rejected just fine. I'll try setting up a second local conduit instance and test with having these two federate. If that doesn't result in anything interesting, I'll try it with Synapse instead, maybe it's a funny interaction.
Sign in to join this conversation.
No labels
Android
CS::needs customer feedback
CS::needs follow up
CS::needs on prem installation
CS::waiting
Chrome
Design:: Ready
Design:: in progress
Design::UX
E2EE
Edge
Firefox
GDPR
Iteration 13 IM
Linux
MacOS
Need::Discussion
Need::Steps to reproduce
Need::Upstream fix
Needs:: Planning
Needs::Dev-Team
Needs::More information
Needs::Priority
Needs::Product
Needs::Refinement
Needs::Severity
Priority::1-Critical
Priority::2-Max
Priority::3-Impending
Priority::4-High
Priority::5-Medium
Priority::6-Low
Priority::7-None
Progress::Backlog
Progress::Review
Progress::Started
Progress::Testing
Progress::Triage
Progress::Waiting
Reporter::Sentry
Safari
Target::Community
Target::Customer
Target::Internal
Target::PoC
Target::Security
Team:Customer-Success
Team:Design
Team:Infrastructure
Team:Instant-Messaging
Team:Product
Team:Workflows
Type::Bug
Type::Design
Type::Documentation
Type::Feature
Type::Improvement
Type::Support
Type::Tests
Windows
blocked
blocked-by-spec
cla-signed
conduit
contribution::advanced
contribution::easy
contribution::help needed
from::review
iOS
p::ti-tenant
performance
product::triage
proposal
refactor
release-blocker
s: dart_openapi_codegen
s::Famedly-Patient
s::Org-Directory
s::Passport-Generator
s::Requeuest
s:CRM
s:Famedly-App
s:Famedly-Web
s:Fhiroxide
s:Fhiroxide-cli
s:Fhiroxide-client
s:Fhirs
s:Hedwig
s:LISA
s:Matrix-Dart-SDK
s:Role-Manager
s:Synapse
s:User-Directory
s:WFS-Matrix
s:Workflow Engine
s:dtls
s:famedly-error
s:fcm-shared-isolate
s:matrix-api-lite
s:multiple-tab-detector
s:native-imaging
severity::1
severity::2
severity::3
severity::4
technical-debt
voip
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Matthias/conduit#418
No description provided.