From df694f6a7d72141e11f12a9cba6f0850a7e8e186 Mon Sep 17 00:00:00 2001 From: Giteabot Date: Mon, 15 Jan 2024 16:05:30 +0800 Subject: [PATCH] Fix nil pointer panic when exec some gitea cli command (#28791) (#28795) Backport #28791 by @yp05327 panic: ![image](https://github.com/go-gitea/gitea/assets/18380374/7fcde2ad-1d42-4b60-b120-3b60a8926e8e) After: ![image](https://github.com/go-gitea/gitea/assets/18380374/49d9f0ca-e590-4a35-8ca2-1317d1b7c939) Co-authored-by: yp05327 <576951401@qq.com> --- modules/private/actions.go | 3 +++ modules/private/key.go | 3 +++ modules/private/mail.go | 3 +++ 3 files changed, 9 insertions(+) diff --git a/modules/private/actions.go b/modules/private/actions.go index c924dac2cd..4ec77dc936 100644 --- a/modules/private/actions.go +++ b/modules/private/actions.go @@ -22,5 +22,8 @@ func GenerateActionsRunnerToken(ctx context.Context, scope string) (string, Resp }) resp, extra := requestJSONResp(req, &responseText{}) + if resp == nil { + return "", extra + } return resp.Text, extra } diff --git a/modules/private/key.go b/modules/private/key.go index 6f7cd87796..aa1e8aa56f 100644 --- a/modules/private/key.go +++ b/modules/private/key.go @@ -27,5 +27,8 @@ func AuthorizedPublicKeyByContent(ctx context.Context, content string) (string, req := newInternalRequest(ctx, reqURL, "POST") req.Param("content", content) resp, extra := requestJSONResp(req, &responseText{}) + if resp == nil { + return "", extra + } return resp.Text, extra } diff --git a/modules/private/mail.go b/modules/private/mail.go index 82216b346b..699f5e5f42 100644 --- a/modules/private/mail.go +++ b/modules/private/mail.go @@ -30,5 +30,8 @@ func SendEmail(ctx context.Context, subject, message string, to []string) (strin }) resp, extra := requestJSONResp(req, &responseText{}) + if resp == nil { + return "", extra + } return resp.Text, extra }