8f0dd9478e
Future releases of GCC are planning to remove[0] default support for
some old features that were removed from C99 but GCC still accepts.
We can test for these changes by using the following -Werror=
directives
-Werror=implicit-int
-Werror=implicit-function-declaration
-Werror=int-conversion
-Werror=strict-prototypes
-Werror=old-style-definition
Doing so revealed an issue with the auto/ tests in that the test
programs always define main as
int main()
rather than
int main(void)
which results in a bunch of errors like
build/autotest.c:3:23: error: function declaration isn't a prototype [-Werror=strict-prototypes]
3 | int main() {
| ^~~~
build/autotest.c: In function 'main':
build/autotest.c:3:23: error: old-style function definition [-Werror=old-style-definition]
The fix was easy, it only required fixing the main prototype with
find -type f -exec sed -i 's/int main() {/int main(void) {/g' {} \;
Regardless of these upcoming GCC changes, this is probably a good thing
to do anyway for correctness.
[0]: https://fedoraproject.org/wiki/Changes/PortingToModernC
Link: <https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/CJXKTLXJUPZ4F2C2VQOTNMEA5JAUPMBD/>
Link: <https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/6SGHPHPAXKCVJ6PUZ57WVDQ5TDBVIRMF/>
Reviewed-by: Alejandro Colomar <alx@nginx.com>
Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
83 lines
2 KiB
Text
83 lines
2 KiB
Text
|
|
# Copyright (C) Igor Sysoev
|
|
# Copyright (C) NGINX, Inc.
|
|
|
|
|
|
# Linux 2.6, FreeBSD 8.2, 9.1, Solaris 11.
|
|
|
|
nxt_feature="posix_fadvise()"
|
|
nxt_feature_name=NXT_HAVE_POSIX_FADVISE
|
|
nxt_feature_run=
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <fcntl.h>
|
|
|
|
int main(void) {
|
|
(void) posix_fadvise(0, 0, 0, POSIX_FADV_WILLNEED);
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
|
|
# FreeBSD 8.0.
|
|
|
|
nxt_feature="fcntl(F_READAHEAD)"
|
|
nxt_feature_name=NXT_HAVE_READAHEAD
|
|
nxt_feature_run=
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <fcntl.h>
|
|
|
|
int main(void) {
|
|
(void) fcntl(0, F_READAHEAD, 1024);
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
|
|
# MacOSX, FreeBSD 8.0.
|
|
|
|
nxt_feature="fcntl(F_RDAHEAD)"
|
|
nxt_feature_name=NXT_HAVE_RDAHEAD
|
|
nxt_feature_run=
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <fcntl.h>
|
|
|
|
int main(void) {
|
|
(void) fcntl(0, F_RDAHEAD, 1);
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
|
|
nxt_feature="openat2()"
|
|
nxt_feature_name=NXT_HAVE_OPENAT2
|
|
nxt_feature_run=
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <fcntl.h>
|
|
#include <unistd.h>
|
|
#include <sys/syscall.h>
|
|
#include <linux/openat2.h>
|
|
#include <string.h>
|
|
|
|
int main(void) {
|
|
struct open_how how;
|
|
|
|
memset(&how, 0, sizeof(how));
|
|
|
|
how.flags = O_RDONLY;
|
|
how.mode = O_NONBLOCK;
|
|
how.resolve = RESOLVE_IN_ROOT
|
|
| RESOLVE_NO_SYMLINKS
|
|
| RESOLVE_NO_XDEV;
|
|
|
|
int fd = syscall(SYS_openat2, AT_FDCWD, \".\",
|
|
&how, sizeof(how));
|
|
if (fd == -1)
|
|
return 1;
|
|
|
|
return 0;
|
|
}"
|
|
. auto/feature
|