8f0dd9478e
Future releases of GCC are planning to remove[0] default support for
some old features that were removed from C99 but GCC still accepts.
We can test for these changes by using the following -Werror=
directives
-Werror=implicit-int
-Werror=implicit-function-declaration
-Werror=int-conversion
-Werror=strict-prototypes
-Werror=old-style-definition
Doing so revealed an issue with the auto/ tests in that the test
programs always define main as
int main()
rather than
int main(void)
which results in a bunch of errors like
build/autotest.c:3:23: error: function declaration isn't a prototype [-Werror=strict-prototypes]
3 | int main() {
| ^~~~
build/autotest.c: In function 'main':
build/autotest.c:3:23: error: old-style function definition [-Werror=old-style-definition]
The fix was easy, it only required fixing the main prototype with
find -type f -exec sed -i 's/int main() {/int main(void) {/g' {} \;
Regardless of these upcoming GCC changes, this is probably a good thing
to do anyway for correctness.
[0]: https://fedoraproject.org/wiki/Changes/PortingToModernC
Link: <https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/CJXKTLXJUPZ4F2C2VQOTNMEA5JAUPMBD/>
Link: <https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/6SGHPHPAXKCVJ6PUZ57WVDQ5TDBVIRMF/>
Reviewed-by: Alejandro Colomar <alx@nginx.com>
Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
139 lines
3.3 KiB
Text
139 lines
3.3 KiB
Text
|
|
# Copyright (C) Igor Sysoev
|
|
# Copyright (C) NGINX, Inc.
|
|
|
|
|
|
NXT_SHM_PREFIX="/"
|
|
|
|
# FreeBSD, Solaris, MacOSX
|
|
|
|
nxt_feature="shm_open()"
|
|
nxt_feature_name=NXT_HAVE_SHM_OPEN
|
|
nxt_feature_run=yes
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <sys/mman.h>
|
|
#include <fcntl.h>
|
|
#include <unistd.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/types.h>
|
|
|
|
int main(void) {
|
|
int ret;
|
|
static char name[] = \"/unit.configure\";
|
|
|
|
shm_unlink(name);
|
|
|
|
int fd = shm_open(name, O_CREAT | O_EXCL | O_RDWR,
|
|
S_IRUSR | S_IWUSR);
|
|
if (fd == -1)
|
|
return 1;
|
|
|
|
ret = (access(name, F_OK) == 0);
|
|
shm_unlink(name);
|
|
|
|
return ret;
|
|
}"
|
|
. auto/feature
|
|
|
|
|
|
if [ $nxt_found = no ]; then
|
|
|
|
# Linux and NetBSD 7.0 shm_open() are in librt.
|
|
|
|
nxt_feature="shm_open() in librt"
|
|
nxt_feature_libs="-lrt"
|
|
. auto/feature
|
|
|
|
if [ $nxt_found = yes ]; then
|
|
NXT_LIBRT=$nxt_feature_libs
|
|
fi
|
|
fi
|
|
|
|
|
|
if [ $nxt_found = no ]; then
|
|
|
|
# DragonFly has no separate namespace for shm_open().
|
|
|
|
nxt_feature="shm_open() in /tmp directory"
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <sys/mman.h>
|
|
#include <fcntl.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/types.h>
|
|
|
|
int main(void) {
|
|
static char name[] = \"/tmp/unit.configure\";
|
|
|
|
shm_unlink(name);
|
|
|
|
int fd = shm_open(name, O_CREAT | O_EXCL | O_RDWR,
|
|
S_IRUSR | S_IWUSR);
|
|
if (fd == -1)
|
|
return 1;
|
|
|
|
shm_unlink(name);
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
if [ $nxt_found = yes ]; then
|
|
NXT_SHM_PREFIX="/tmp/"
|
|
fi
|
|
fi
|
|
|
|
nxt_shm_open_found=$nxt_found
|
|
|
|
|
|
# FreeBSD 8.0
|
|
|
|
nxt_feature="shm_open(SHM_ANON)"
|
|
nxt_feature_name=NXT_HAVE_SHM_OPEN_ANON
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <sys/mman.h>
|
|
#include <fcntl.h>
|
|
#include <sys/stat.h>
|
|
|
|
int main(void) {
|
|
int fd = shm_open(SHM_ANON, O_RDWR, S_IRUSR | S_IWUSR);
|
|
if (fd == -1)
|
|
return 1;
|
|
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
if [ "$nxt_shm_open_found" = no ]; then
|
|
nxt_shm_open_found=$nxt_found
|
|
fi
|
|
|
|
|
|
# Linux
|
|
|
|
nxt_feature="memfd_create()"
|
|
nxt_feature_name=NXT_HAVE_MEMFD_CREATE
|
|
nxt_feature_run=yes
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <linux/memfd.h>
|
|
#include <unistd.h>
|
|
#include <sys/syscall.h>
|
|
|
|
int main(void) {
|
|
static char name[] = \"/unit.configure\";
|
|
|
|
int fd = syscall(SYS_memfd_create, name, MFD_CLOEXEC);
|
|
if (fd == -1)
|
|
return 1;
|
|
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
|
|
if [ "$nxt_shm_open_found$nxt_found" = nono ]; then
|
|
$echo
|
|
$echo $0: error: no shared memory implementation found.
|
|
$echo
|
|
exit 1;
|
|
fi
|