Config won't parse CONDUIT_MAX_REQUEST_SIZE "20_000_000" as u32 #289

Open
opened 2022-07-10 01:01:04 +00:00 by jblachly · 4 comments
jblachly commented 2022-07-10 01:01:04 +00:00 (Migrated from gitlab.com)

Description

Using the Docker deployment documentation with 0.4, conduit aborts on startup:

It looks like your config is invalid. The following error occured while parsing it: invalid type: found string "20_000_000", expected u32 for key "MAX_REQUEST_SIZE" in `CONDUIT_` environment variable(s)

Changing this to "20000000" resolves the issue.

Is it possible that the switch to axum and a different configuration provider (previously used Rocket's?) no longer parse Rust style thousands separators?

System Configuration

Conduit Version: 0.4 (using docker container :latest)
Database backend (default is sqlite): rocksdb

### Description Using the Docker deployment documentation with 0.4, conduit aborts on startup: ``` It looks like your config is invalid. The following error occured while parsing it: invalid type: found string "20_000_000", expected u32 for key "MAX_REQUEST_SIZE" in `CONDUIT_` environment variable(s) ``` Changing this to "20000000" resolves the issue. Is it possible that the switch to axum and a different configuration provider (previously used Rocket's?) no longer parse Rust style thousands separators? ### System Configuration Conduit Version: 0.4 (using docker container :latest) Database backend (default is sqlite): rocksdb
jblachly commented 2022-07-16 14:48:42 +00:00 (Migrated from gitlab.com)

mentioned in issue #228

mentioned in issue #228
timokoesters commented 2022-10-09 08:35:07 +00:00 (Migrated from gitlab.com)

`found string "20_000_000"

It should not be a string. Something like this works for me:
max_request_size = 300_000_000

> `found string "20_000_000" It should not be a string. Something like this works for me: `max_request_size = 300_000_000`
timokoesters commented 2022-10-09 13:26:15 +00:00 (Migrated from gitlab.com)

Opening again. The underscores work in the conduit.toml but not in env vars

Opening again. The underscores work in the conduit.toml but not in env vars
jblachly commented 2023-11-08 15:14:36 +00:00 (Migrated from gitlab.com)

mentioned in issue #402

mentioned in issue #402
Sign in to join this conversation.
No labels
Android
CS::needs customer feedback
CS::needs follow up
CS::needs on prem installation
CS::waiting
Chrome
Design:: Ready
Design:: in progress
Design::UX
E2EE
Edge
Firefox
GDPR
Iteration 13 IM
Linux
MacOS
Need::Discussion
Need::Steps to reproduce
Need::Upstream fix
Needs:: Planning
Needs::Dev-Team
Needs::More information
Needs::Priority
Needs::Product
Needs::Refinement
Needs::Severity
Priority::1-Critical
Priority::2-Max
Priority::3-Impending
Priority::4-High
Priority::5-Medium
Priority::6-Low
Priority::7-None
Progress::Backlog
Progress::Review
Progress::Started
Progress::Testing
Progress::Triage
Progress::Waiting
Reporter::Sentry
Safari
Target::Community
Target::Customer
Target::Internal
Target::PoC
Target::Security
Team:Customer-Success
Team:Design
Team:Infrastructure
Team:Instant-Messaging
Team:Product
Team:Workflows
Type::Bug
Type::Design
Type::Documentation
Type::Feature
Type::Improvement
Type::Support
Type::Tests
Windows
blocked
blocked-by-spec
cla-signed
conduit
contribution::advanced
contribution::easy
contribution::help needed
from::review
iOS
p::ti-tenant
performance
product::triage
proposal
refactor
release-blocker
s: dart_openapi_codegen
s::Famedly-Patient
s::Org-Directory
s::Passport-Generator
s::Requeuest
s:CRM
s:Famedly-App
s:Famedly-Web
s:Fhiroxide
s:Fhiroxide-cli
s:Fhiroxide-client
s:Fhirs
s:Hedwig
s:LISA
s:Matrix-Dart-SDK
s:Role-Manager
s:Synapse
s:User-Directory
s:WFS-Matrix
s:Workflow Engine
s:dtls
s:famedly-error
s:fcm-shared-isolate
s:matrix-api-lite
s:multiple-tab-detector
s:native-imaging
severity::1
severity::2
severity::3
severity::4
technical-debt
voip
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Matthias/conduit#289
No description provided.